forked from vercel/next.js
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Disable more Turbopack build tests (vercel#59245)
## What? Skips more tests that are running `next build` which is not supported by Turbopack yet. ## How? Used an approach where all `next build` tests would fail if `TURBOPACK=1` is set, which is how the tests run. This highlighted the cases `next build` was still running. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Closes NEXT-1791
- Loading branch information
1 parent
445e705
commit c1fba57
Showing
5 changed files
with
456 additions
and
438 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,96 +1,98 @@ | ||
import { nextBuild } from 'next-test-utils' | ||
|
||
describe('ppr build errors', () => { | ||
let stderr: string | ||
let stdout: string | ||
;(process.env.TURBOPACK ? describe.skip : describe)('production mode', () => { | ||
let stderr: string | ||
let stdout: string | ||
|
||
beforeAll(async () => { | ||
const output = await nextBuild(__dirname, [], { | ||
stderr: true, | ||
stdout: true, | ||
}) | ||
stderr = output.stderr | ||
stdout = output.stdout | ||
}) | ||
|
||
describe('within a suspense boundary', () => { | ||
it('should fail the build for uncaught prerender errors', async () => { | ||
expect(stderr).toContain( | ||
'Error occurred prerendering page "/regular-error-suspense-boundary".' | ||
) | ||
beforeAll(async () => { | ||
const output = await nextBuild(__dirname, [], { | ||
stderr: true, | ||
stdout: true, | ||
}) | ||
stderr = output.stderr | ||
stdout = output.stdout | ||
}) | ||
|
||
describe('when a postpone call was made but missing postpone data', () => { | ||
it('should fail the build', async () => { | ||
describe('within a suspense boundary', () => { | ||
it('should fail the build for uncaught prerender errors', async () => { | ||
expect(stderr).toContain( | ||
'Prerendering / needs to partially bail out because something dynamic was used. ' | ||
'Error occurred prerendering page "/regular-error-suspense-boundary".' | ||
) | ||
}) | ||
|
||
it('should fail the build & surface any errors that were thrown by user code', async () => { | ||
// in the case of catching a postpone and throwing a new error, we log the error that the user threw to help with debugging | ||
expect(stderr).toContain( | ||
'Prerendering /re-throwing-error needs to partially bail out because something dynamic was used. ' | ||
) | ||
expect(stderr).toContain( | ||
'The following error was thrown during build, and may help identify the source of the issue:' | ||
) | ||
expect(stderr).toContain( | ||
'Error: The original error was caught and rethrown.' | ||
) | ||
describe('when a postpone call was made but missing postpone data', () => { | ||
it('should fail the build', async () => { | ||
expect(stderr).toContain( | ||
'Prerendering / needs to partially bail out because something dynamic was used. ' | ||
) | ||
}) | ||
|
||
// the regular pre-render error should not be thrown as well, as we've already logged a more specific error | ||
expect(stderr).not.toContain( | ||
'Error occurred prerendering page "/re-throwing-error"' | ||
) | ||
}) | ||
}) | ||
}) | ||
it('should fail the build & surface any errors that were thrown by user code', async () => { | ||
// in the case of catching a postpone and throwing a new error, we log the error that the user threw to help with debugging | ||
expect(stderr).toContain( | ||
'Prerendering /re-throwing-error needs to partially bail out because something dynamic was used. ' | ||
) | ||
expect(stderr).toContain( | ||
'The following error was thrown during build, and may help identify the source of the issue:' | ||
) | ||
expect(stderr).toContain( | ||
'Error: The original error was caught and rethrown.' | ||
) | ||
|
||
describe('outside of a suspense boundary', () => { | ||
it('should fail the build for uncaught errors', async () => { | ||
expect(stderr).toContain( | ||
'Error occurred prerendering page "/regular-error".' | ||
) | ||
// the regular pre-render error should not be thrown as well, as we've already logged a more specific error | ||
expect(stderr).not.toContain( | ||
'Error occurred prerendering page "/re-throwing-error"' | ||
) | ||
}) | ||
}) | ||
}) | ||
|
||
describe('when a postpone call was made but missing postpone data', () => { | ||
it('should fail the build', async () => { | ||
describe('outside of a suspense boundary', () => { | ||
it('should fail the build for uncaught errors', async () => { | ||
expect(stderr).toContain( | ||
'Prerendering /no-suspense-boundary needs to partially bail out because something dynamic was used. ' | ||
) | ||
|
||
// the regular pre-render error should not be thrown as well, as we've already logged a more specific error | ||
expect(stderr).not.toContain( | ||
'Error occurred prerendering page "/no-suspense-boundary"' | ||
'Error occurred prerendering page "/regular-error".' | ||
) | ||
}) | ||
|
||
it('should fail the build & surface any errors that were thrown by user code', async () => { | ||
// in the case of catching a postpone and throwing a new error, we log the error that the user threw to help with debugging | ||
expect(stderr).toContain( | ||
'Prerendering /no-suspense-boundary-re-throwing-error needs to partially bail out because something dynamic was used. ' | ||
) | ||
expect(stderr).toContain( | ||
'The following error was thrown during build, and may help identify the source of the issue:' | ||
) | ||
expect(stderr).toContain( | ||
"Error: Throwing a new error from 'no-suspense-boundary-re-throwing-error'" | ||
) | ||
describe('when a postpone call was made but missing postpone data', () => { | ||
it('should fail the build', async () => { | ||
expect(stderr).toContain( | ||
'Prerendering /no-suspense-boundary needs to partially bail out because something dynamic was used. ' | ||
) | ||
|
||
// the regular pre-render error should not be thrown as well, as we've already logged a more specific error | ||
expect(stderr).not.toContain( | ||
'Error occurred prerendering page "/no-suspense-boundary-re-throwing-error"' | ||
) | ||
// the regular pre-render error should not be thrown as well, as we've already logged a more specific error | ||
expect(stderr).not.toContain( | ||
'Error occurred prerendering page "/no-suspense-boundary"' | ||
) | ||
}) | ||
|
||
it('should fail the build & surface any errors that were thrown by user code', async () => { | ||
// in the case of catching a postpone and throwing a new error, we log the error that the user threw to help with debugging | ||
expect(stderr).toContain( | ||
'Prerendering /no-suspense-boundary-re-throwing-error needs to partially bail out because something dynamic was used. ' | ||
) | ||
expect(stderr).toContain( | ||
'The following error was thrown during build, and may help identify the source of the issue:' | ||
) | ||
expect(stderr).toContain( | ||
"Error: Throwing a new error from 'no-suspense-boundary-re-throwing-error'" | ||
) | ||
|
||
// the regular pre-render error should not be thrown as well, as we've already logged a more specific error | ||
expect(stderr).not.toContain( | ||
'Error occurred prerendering page "/no-suspense-boundary-re-throwing-error"' | ||
) | ||
}) | ||
}) | ||
}) | ||
}) | ||
|
||
describe('when a postpone call is caught and logged it should', () => { | ||
it('should include a message telling why', async () => { | ||
expect(stdout).toContain( | ||
'Logged error: This page needs to bail out of prerendering at this point because it used cookies.' | ||
) | ||
describe('when a postpone call is caught and logged it should', () => { | ||
it('should include a message telling why', async () => { | ||
expect(stdout).toContain( | ||
'Logged error: This page needs to bail out of prerendering at this point because it used cookies.' | ||
) | ||
}) | ||
}) | ||
}) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.