Some Gruntfile fixes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Underscore dependency at extensions were removed, I think the one at components should be good enough as an example.
Apparently requirejs may automatically copy files between app and dist. So I remove `copy' from build task. May need some review on this.
|
This LGTM. Thanks for taking the time to put this together, @fudanchii! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes to make jshint actually check files under extensions and components folder. as discussed in #6
And some requirejs config as pointed by @addyosmani in #14
With this, hopefully we can have some basic optimization for `dist' files. I think I also want to concatenate extensions and components files together, but the work would be a bit messy, so I'll leave it at this for now.