Fix duplicate ajax requests #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pl12133
reviewed
Feb 25, 2017
| cachedCallback(response); | ||
| }); | ||
| }); | ||
| requestCache[href] = response; |
There was a problem hiding this comment.
That's a smart way to combine the two cache objects into one.
developit
approved these changes
Feb 25, 2017
developit
reviewed
Feb 25, 2017
| callback(requestCache[href]); | ||
| return; | ||
| } | ||
| else if (cacheEntryType === 'object') { |
There was a problem hiding this comment.
Just double checking: will requestCache[href] ever be null (eg: failed xhr)? If so, might be worth a truthiness check.
There was a problem hiding this comment.
requestCache[href] will be undefined initially, an array until the request is finished and a string afterwards. Failed XHRs are saved as an empty string, so it should never be null.
There was a problem hiding this comment.
Perfect, that's what I figured but just wanted to make sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #35, #27