Memory leak fix #38
Merged
Memory leak fix #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an inline style element (without cssRules attached as it is inline and not coming from a file) is deleted, the reference is kept inside `processedSheets`, creating a memory leak. Also added a small optimization to avoid a try catch, as [they are a bit expensive](https://stackoverflow.com/questions/38121208/why-cant-v8-optimize-try-catch-finally)
|
Thank you for the pull request! The try catch is needed because browsers throw a I added a unit test for your fix in 6992479. Once the cross browser tests on BrowserStack run through I will merge it. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an inline style element is deleted, the reference is kept inside
processedSheets, creating a memory leak.Also added a small optimization to avoid a try catch, as they are a bit expensive
EDIT: Removed try/catch thingy, as tests failed because of that.