Skip to content

fix: prevent dumping JSON files with keyword preserve markers in client grants#1040

Merged
kushalshit27 merged 5 commits intomasterfrom
DXCDT-925-github-issue-802
Mar 11, 2025
Merged

fix: prevent dumping JSON files with keyword preserve markers in client grants#1040
kushalshit27 merged 5 commits intomasterfrom
DXCDT-925-github-issue-802

Conversation

@kushalshit27
Copy link
Copy Markdown
Contributor

@kushalshit27 kushalshit27 commented Feb 27, 2025

🔧 Changes

Prevent dumping JSON files with keyword preserve markers in client grants

📚 References

#802

🔬 Testing

Test pass ✅

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@kushalshit27 kushalshit27 changed the title Prevent dumping JSON files with keyword preserve markers in client grants fix: prevent dumping JSON files with keyword preserve markers in client grants Feb 27, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.14%. Comparing base (0697bf6) to head (7d8cb8a).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
src/context/directory/handlers/clientGrants.ts 64.28% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
- Coverage   80.18%   80.14%   -0.05%     
==========================================
  Files         125      125              
  Lines        4593     4603      +10     
  Branches      898      903       +5     
==========================================
+ Hits         3683     3689       +6     
- Misses        539      540       +1     
- Partials      371      374       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kushalshit27 kushalshit27 marked this pull request as ready for review February 28, 2025 04:12
@kushalshit27 kushalshit27 requested a review from a team as a code owner February 28, 2025 04:12
@kushalshit27 kushalshit27 merged commit 6b6e12e into master Mar 11, 2025
8 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-925-github-issue-802 branch March 11, 2025 08:45
@kushalshit27 kushalshit27 mentioned this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants