Skip to content

Conversation

@glensc
Copy link
Contributor

@glensc glensc commented Feb 6, 2023

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

The middleware must be void, not return things.

Reverts breakage from bbd3606

Checklist

  • This change adds test coverage for new/changed/fixed functionality
  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

The middleware must be void, not return things

Reverts breakage from bbd3606
@glensc
Copy link
Contributor Author

glensc commented Feb 6, 2023

Could the maintainers here:

  1. create atomic commits, not monstrous commits like bbd3606 that changed many things at once
  2. maintainers also create pull requests to have review and reasoning explained with the changes.

I think this is already 3rd problem reported by that same commit.

@glensc
Copy link
Contributor Author

glensc commented Feb 7, 2023

@jfromaniello another fix to a breaking change

@glensc
Copy link
Contributor Author

glensc commented Mar 25, 2024

can this be revieved and merged and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant