Add skeleton shimmer loading to card screens#47
Open
Sudhanshu96 wants to merge 1 commit into
Open
Conversation
…or Authenticator cards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the spinner-based loading states on the auth-method card screens with a reusable, theme-aware skeleton shimmer system. Placeholders mirror the loaded layout, so there's no layout shift when data arrives, and the loading state reads more clearly than a centered spinner.
📋 Changes
Added the following files:
Shimmer.swift- animation engine +.shimmering()modifier; Theme(light/dark) mode agnosticSkeletonShape.swift- placeholder primitive (.text/.rounded/.circle/.capsule) +.skeleton(_:)redaction modifier.*SkeletonCards.swift**-SkeletonList,SkeletonCard, andAuthMethodCardSkeleton/SavedAuthenticatorCardSkeleton.Note: No View model changes required since it wires up with the existing
viewModel.showLoader📹 Screen Recording
Light Mode
shimmer_light.mp4
Dark Mode
shimmer_dark.mp4