Change strict reading PG to only return rows when valid #2219
+153
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/datastore
josephschorr
force-pushed
the
strict-read-first
branch
from
8c341b4 to
cdc7f5a
Compare
This is necessary for the error and retry logic to work in the strict read proxy
josephschorr
force-pushed
the
strict-read-first
branch
from
cdc7f5a to
79c24fd
Compare
vroldanbet
approved these changes
Jan 31, 2025
| @@ -79,14 +79,14 @@ func TestReplicatedReaderReturnsExpectedError(t *testing.T) { | |||
| } | |||
|
|
|||
| type fakeDatastore struct { | |||
| isPrimary bool | |||
| revision datastore.Revision | |||
| state string | |||
There was a problem hiding this comment.
So I can have more test cases
| require.NotEmpty(found) | ||
|
|
||
| // Perform a read at a manually constructed revision beyond head, which should fallback to the primary. | ||
| badRev := postgresRevision{ |
There was a problem hiding this comment.
can you test the replica and make sure it does return error with this revision?
There was a problem hiding this comment.
We do in the other test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for the error and retry logic to work in the strict read proxy