Skip to content

Conversation

@clostao
Copy link
Member

@clostao clostao commented Oct 3, 2025

Issue

There was some outdated tests failing that bypassed the CI/CD pipeline due to a misconfiguration in the workflow.

Solution

Fix tests & fix workflow configuration

@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for auto-drive-demo ready!

Name Link
🔨 Latest commit 5258316
🔍 Latest deploy log https://app.netlify.com/projects/auto-drive-demo/deploys/68dfca74e3e74700080bbd59
😎 Deploy Preview https://deploy-preview-502--auto-drive-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment @cursor review or bugbot run to trigger another review on this PR

@clostao clostao requested a review from jfrank-summit October 3, 2025 12:37
teor2345
teor2345 previously approved these changes Oct 3, 2025
Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine apart from the failing test. Not sure if the AI is correct here, I think we fixed that issue already elsewhere.

@clostao
Copy link
Member Author

clostao commented Oct 3, 2025

I fixed the build issue, AI is not right, allowing duplicates is the way to go

Copy link
Member

@jfrank-summit jfrank-summit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clostao clostao merged commit 1d09e41 into main Oct 6, 2025
7 checks passed
@clostao clostao deleted the fix-testing branch October 6, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants