Skip to content

deprecate installer script#182

Merged
joemiller merged 1 commit into
mainfrom
joem/deprecate-install-script
May 14, 2026
Merged

deprecate installer script#182
joemiller merged 1 commit into
mainfrom
joem/deprecate-install-script

Conversation

@joemiller
Copy link
Copy Markdown
Member

The install script used by the curl -sL https://git.io/autotag-install | sh instructions was generated by godownloader years ago and does provide a way to verify against a checksum provided as input. While it does verify checksums downloaded from github releases, this is not sufficient in the current era of increasing supply chain attacks. An attacker could compromise the github repo and replace any release binary along with checksums.

Recommend users manually (or using automation) retrieve version + checksum and hardcode both in their CI pipelines.

@joemiller joemiller requested a review from a team as a code owner May 14, 2026 14:38
@threeiem
Copy link
Copy Markdown
Contributor

Should we consider something like sigstore to keep the signatures safe from compromised maintainers as well.

Copy link
Copy Markdown
Contributor

@threeiem threeiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm plus one for alerting users in light of recent supply chain attacks. My nits and suggestions don't stop this from being merged though.

Comment thread README.md Outdated
The install script used by the `curl -sL https://git.io/autotag-install | sh` instructions was generated by godownloader years ago and does provide a way to verify against a checksum provided as input. While it does verify checksums downloaded from github releases, this is not sufficient in the current era of increasing supply chain attacks. An attacker could compromise the github repo and replace any release binary along with checksums.

Recommend users manually (or using automation) retrieve version + checksum and hardcode both in their CI pipelines.
@joemiller joemiller force-pushed the joem/deprecate-install-script branch from 229b84e to e8a87f3 Compare May 14, 2026 15:52
@joemiller
Copy link
Copy Markdown
Member Author

Should we consider something like sigstore to keep the signatures safe from compromised maintainers as well.

good idea. There is also this, GA'd late 2025, I was not aware of it - https://docs.github.com/en/code-security/concepts/supply-chain-security/immutable-releases

Copy link
Copy Markdown

@winmillwill winmillwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to moving on from godownloader, other benefits are gravy

@joemiller joemiller merged commit d0176cb into main May 14, 2026
8 checks passed
@joemiller joemiller deleted the joem/deprecate-install-script branch May 14, 2026 17:04
@threeiem
Copy link
Copy Markdown
Contributor

Should we consider something like sigstore to keep the signatures safe from compromised maintainers as well.

good idea. There is also this, GA'd late 2025, I was not aware of it - https://docs.github.com/en/code-security/concepts/supply-chain-security/immutable-releases

Seems like releases should have been immutable from the beginning. It is crazy to think you can release code and then rerelease different code as the same release. 😵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants