ConvertSubnetToL1 P Chain Tx #153
Conversation
| } | ||
| } | ||
|
|
||
| func Filter[T any](input []T, f func(T) bool) []T { |
There was a problem hiding this comment.
could you add description for this?
There was a problem hiding this comment.
this is straight from CLI utils pkg
| return pClient.GetSubnet(ctx, subnetID) | ||
| } | ||
|
|
||
| func ConvertToBLSProofOfPossession(publicKey, proofOfPossesion string) (signer.ProofOfPossession, error) { |
There was a problem hiding this comment.
Probably the name should be NewSignerProofOfPossession.
Besides this, I don't think it belongs to blockchain/. It most probably belongs to utils/, or pchain/utils/
| "github.com/ava-labs/avalanchego/vms/platformvm/txs" | ||
| ) | ||
|
|
||
| // ConvertSubnetToL1TxParams contains all parameters needed to create a ConvertSubnetToL1Tx |
There was a problem hiding this comment.
ok I agree with this structs to have more compat with TS, will also do in my PR
| Address []byte | ||
| // Validators are the initial set of L1 validators after the conversion. | ||
| Validators []*txs.ConvertSubnetToL1Validator | ||
| // Wallet is the wallet used to sign `ConvertSubnetToL1Tx` |
There was a problem hiding this comment.
I believe wallet should like outside of this struct, and be a separate argument, as in my PR, so NewConvertSubnetToL1Tx will take the wallet/client, and the params.
With this be have more similarity to TS and I believe it is best organization of the input as the wallet serves
other function, is not part of the tx data
| // ConvertSubnetToL1TxParams contains all parameters needed to create a ConvertSubnetToL1Tx | ||
| type ConvertSubnetToL1TxParams struct { | ||
| // SubnetAuthKeys are the keys used to sign `ConvertSubnetToL1Tx` | ||
| SubnetAuthKeys []ids.ShortID |
There was a problem hiding this comment.
if you agree, we can incorporate the simplifications of strings instead of ids.ID, etc, so we are more
similar to TS, and maybe it may be easier for users
| } | ||
|
|
||
| func main() { | ||
| if err := ConvertL1(); err != nil { |
| "github.com/ethereum/go-ethereum/common" | ||
| ) | ||
|
|
||
| func ConvertL1() error { |
There was a problem hiding this comment.
can you make this very similar to https://github.com/javiertc/avalanche-sdk-test/blob/main/convertSubnetToL1Tx.ts ?
There was a problem hiding this comment.
this way you will check what is being used and the separate parts: chain, account, wallet, functions
There was a problem hiding this comment.
you can also try to refer to my example with is pretty much based on https://github.com/javiertc/avalanche-sdk-test/blob/main/createSubnetAndChain.ts
There was a problem hiding this comment.
will refactor to be only usign wallet, need to create PR for that
| "P-fujixxx", // Replace with actual addresses | ||
| } | ||
|
|
||
| network := network.FujiNetwork() |
There was a problem hiding this comment.
can you take the network endpoint from env var as in my example
There was a problem hiding this comment.
why do we want to use env var as opposed to just declaring it in example?
| } | ||
|
|
||
| network := network.FujiNetwork() | ||
| keychain, err := keychain.NewKeychain(network, privateKeyFilePath, nil) |
There was a problem hiding this comment.
lets create keychain from string private key in env var
There was a problem hiding this comment.
same here switching to wallet
|
|
||
| deployer := txs.NewPublicDeployer(keychain, network) | ||
|
|
||
| wallet, err := wallet.New( |
There was a problem hiding this comment.
probably my new wallet interface is better as it does directly receives SDK objects
ConvertSubnetToL1 P-Chain Tx