Skip to content

Fix wrong test badges when using local nodes with correct network id #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix wrong test badges when using local nodes with correct network id #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/NetworkSettings/NetworkMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export default class NetworkMenu extends Vue {
let net = this.activeNetwork

if (!net) return false
if (net.networkId !== 1) return true
if (+net.networkId !== 1) return true
return false
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/TestNetBanner.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default {
isVisible() {
let network = this.$store.state.Network.selectedNetwork
if (!network) return false
let netId = network.networkId
let netId = +network.networkId

if (netId === 1) return false
return true
Expand Down