L-12 Wrong Usage of reinitializer Modifier #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
iansuvak,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
mdelle1
iansuvak
approved these changes
Apr 11, 2025
geoff-vball
approved these changes
Apr 11, 2025
github-project-automation
bot
moved this from Backlog 🗄️
to In Review 👀
in Platform Engineering Group
bernard-avalabs
approved these changes
Apr 14, 2025
github-project-automation
bot
moved this from In Review 👀
to Done ✅
in Platform Engineering Group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Changes the
StakingManagerconcrete contracts to useinitializerrather thanreinitializer(2)on theirinitializefunctions.reinitializer(2)was used in the inheritance based model in the v1 contracts to implement PoA -> PoS migration. Now thatStakingManageris standalone fromValidatorManager, they should both only ever be initialized once.How this works
Change
reinitializer(2)toinitializerHow this was tested
CI
How is this documented
N/A