Skip to content

Adding mypy#886

Open
mariano wants to merge 2 commits intomainfrom
mypy
Open

Adding mypy#886
mariano wants to merge 2 commits intomainfrom
mypy

Conversation

@mariano
Copy link
Collaborator

@mariano mariano commented Jan 9, 2026

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

call = (
event.payload.get("call")
if isinstance(event.payload, dict)
else None

P2 Badge Handle TOOL_PROCESS payloads with calls in MCP router

ToolCallResponseParser now emits EventType.TOOL_PROCESS with payload={"calls": [...]} (see src/avalan/model/response/parsers/tool.py), but _tool_call_event_item only looks for list payloads or payload["call"]. When the payload is a dict with "calls", call stays None and this function returns None, so _tool_event_notifications skips emitting tool.call events and tool summaries for MCP clients. This breaks tool-call notifications whenever streaming tool calls are parsed. Consider extracting the first call from payload["calls"] as you do in other routers.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant