Prevent m3u8 reload from being added multiple times #6647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related issue: #6635 The root cause of the behavior was a race condition where the first load would sometimes take long enough for the m3u8 reload initialization to be triggered twice or more. This resulted in multiple event listeners, each creating a reload interval when pausing playback. However, these intervals were being set to the same variable so when playback was resumed the interval removal would only remove the most recently created interval. Using a flag specific to the reload being added to the page should fix the behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #6635
The root cause of the behavior was a race condition where the first load would sometimes take long enough for the m3u8 reload initialization to be triggered twice or more. This resulted in multiple event listeners, each creating a reload interval when pausing playback. However, these intervals were being set to the same variable so when playback was resumed the interval removal would only remove the most recently created interval. Using a flag specific to the reload being added to the page should fix the behavior.