Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle categories / Fix #4 #17

Merged
merged 6 commits into from
Mar 6, 2015
Merged

Handle categories / Fix #4 #17

merged 6 commits into from
Mar 6, 2015

Conversation

laedit
Copy link
Contributor

@laedit laedit commented Mar 3, 2015

Fix #4: Categories are removed only if they are at the end of the line, and multiple categories for one item are possible:
Input:

- This is a +new list item.
- This is a +Fix list item.
- This is a +Change list item.
- +New features are everyone's favorites.
- This is a list item for a +Developer.
- This is a +super-special custom list item.
- This is my last +DEVELOPER list item. +New

Html processed:

  • {New}This is a new list item.
  • {Fix}This is a Fix list item.
  • {Change}This is a Change list item.
  • {New}New features are everyone's favorites.
  • {Developer}This is a list item for a Developer.
  • {Super Special}This is a super-special custom list item.
  • {Developer, New}This is my last DEVELOPER list item.

What do you think?

@avanderhoorn
Copy link
Owner

Great PR! Do we want to increment the version number of the spec to 0.4-beta?

@laedit
Copy link
Contributor Author

laedit commented Mar 4, 2015

I wasn't sure about that, since all definition was in the v0.3.0 and only the parser adaptation was missing.

@avanderhoorn
Copy link
Owner

Great point. But this includes multiple categories and that is an additional feature... hence my thinking there.

@laedit
Copy link
Contributor Author

laedit commented Mar 4, 2015

Yes, good point, I have bumped the version number to 0.4.

@avanderhoorn
Copy link
Owner

Huge favour, can you make it 0.4-beta. Just thinking that gives us room to make other changes in this release without having to race through version numbers.

@laedit
Copy link
Contributor Author

laedit commented Mar 5, 2015

My bad, I haven't see the "-beta" in your previous message.

@avanderhoorn
Copy link
Owner

So we good to go?

@laedit
Copy link
Contributor Author

laedit commented Mar 6, 2015

Yes, sorry about the last commits, I haven't see that my modifications had some side effects.

avanderhoorn added a commit that referenced this pull request Mar 6, 2015
@avanderhoorn avanderhoorn merged commit dacf877 into avanderhoorn:master Mar 6, 2015
@laedit laedit deleted the Handle-categories branch March 7, 2015 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "Category" to be more free-form
2 participants