Conversation
Update the JuliaSyntax/JuliaLowering pins from 2fefd0127e to 537a4c16f1. The JuliaLowering bugfix batch JuliaLang/julia#62862 included in this range changes two behaviors JETLS relied on, so this commit also adapts the affected code paths: - Old-style macro invocation failures are now rethrown wrapped as `LoadError(file, line, MacroExpansionError(...))` instead of a bare `MacroExpansionError`, so the `err isa JL.MacroExpansionError` check in `per_stmt_diagnostics!` no longer matched and macro expansion error diagnostics silently disappeared. The catch handler now unwraps the `LoadError` before dispatching on the error type. - `expand_struct_def`/`expand_typegroup_def` now emit an explicit `global` declaration for the type name ahead of the lowered definition. That node resolves to a `:global` binding distinct from the internal one the type-alias normalization in `compute_binding_occurrences` re-keys onto, so the struct name gained a duplicate `:decl` occurrence. Such same-`(mod, name)` global entries are now folded into the alias target, skipping occurrences already covered at the same byte range. Both regressions were caught by the existing test suite (`test_lowering_diagnostic.jl` and `test_occurrence_analysis.jl`); the full suite passes with this commit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #883 +/- ##
==========================================
+ Coverage 79.89% 79.90% +0.01%
==========================================
Files 63 63
Lines 14103 14121 +18
==========================================
+ Hits 11267 11284 +17
- Misses 2836 2837 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the JuliaSyntax/JuliaLowering pins from 2fefd0127e to 537a4c16f1. The JuliaLowering bugfix batch JuliaLang/julia#62862 included in this range changes two behaviors JETLS relied on, so this commit also adapts the affected code paths:
Old-style macro invocation failures are now rethrown wrapped as
LoadError(file, line, MacroExpansionError(...))instead of a bareMacroExpansionError, so theerr isa JL.MacroExpansionErrorcheck inper_stmt_diagnostics!no longer matched and macro expansion error diagnostics silently disappeared. The catch handler now unwraps theLoadErrorbefore dispatching on the error type.expand_struct_def/expand_typegroup_defnow emit an explicitglobaldeclaration for the type name ahead of the lowered definition. That node resolves to a:globalbinding distinct from the internal one the type-alias normalization incompute_binding_occurrencesre-keys onto, so the struct name gained a duplicate:decloccurrence. Such same-(mod, name)global entries are now folded into the alias target, skipping occurrences already covered at the same byte range.Both regressions were caught by the existing test suite (
test_lowering_diagnostic.jlandtest_occurrence_analysis.jl); the full suite passes with this commit.