Skip to content

deps: Update JS/JL revisions and adapt to JuliaLang/julia#62862 - #883

Merged
aviatesk merged 1 commit into
masterfrom
up-JSJL
Aug 29, 2026
Merged

deps: Update JS/JL revisions and adapt to JuliaLang/julia#62862#883
aviatesk merged 1 commit into
masterfrom
up-JSJL

Conversation

@aviatesk

Copy link
Copy Markdown
Owner

Update the JuliaSyntax/JuliaLowering pins from 2fefd0127e to 537a4c16f1. The JuliaLowering bugfix batch JuliaLang/julia#62862 included in this range changes two behaviors JETLS relied on, so this commit also adapts the affected code paths:

  • Old-style macro invocation failures are now rethrown wrapped as LoadError(file, line, MacroExpansionError(...)) instead of a bare MacroExpansionError, so the err isa JL.MacroExpansionError check in per_stmt_diagnostics! no longer matched and macro expansion error diagnostics silently disappeared. The catch handler now unwraps the LoadError before dispatching on the error type.

  • expand_struct_def/expand_typegroup_def now emit an explicit global declaration for the type name ahead of the lowered definition. That node resolves to a :global binding distinct from the internal one the type-alias normalization in compute_binding_occurrences re-keys onto, so the struct name gained a duplicate :decl occurrence. Such same-(mod, name) global entries are now folded into the alias target, skipping occurrences already covered at the same byte range.

Both regressions were caught by the existing test suite (test_lowering_diagnostic.jl and test_occurrence_analysis.jl); the full suite passes with this commit.

Update the JuliaSyntax/JuliaLowering pins from 2fefd0127e to
537a4c16f1. The JuliaLowering bugfix batch JuliaLang/julia#62862
included in this range changes two behaviors JETLS relied on, so this
commit also adapts the affected code paths:

- Old-style macro invocation failures are now rethrown wrapped as
  `LoadError(file, line, MacroExpansionError(...))` instead of a bare
  `MacroExpansionError`, so the `err isa JL.MacroExpansionError` check
  in `per_stmt_diagnostics!` no longer matched and macro expansion
  error diagnostics silently disappeared. The catch handler now
  unwraps the `LoadError` before dispatching on the error type.

- `expand_struct_def`/`expand_typegroup_def` now emit an explicit
  `global` declaration for the type name ahead of the lowered
  definition. That node resolves to a `:global` binding distinct from
  the internal one the type-alias normalization in
  `compute_binding_occurrences` re-keys onto, so the struct name
  gained a duplicate `:decl` occurrence. Such same-`(mod, name)`
  global entries are now folded into the alias target, skipping
  occurrences already covered at the same byte range.

Both regressions were caught by the existing test suite
(`test_lowering_diagnostic.jl` and `test_occurrence_analysis.jl`);
the full suite passes with this commit.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.90%. Comparing base (6cdac63) to head (ed07e64).
⚠️ Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
src/analysis/occurrence-analysis.jl 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
+ Coverage   79.89%   79.90%   +0.01%     
==========================================
  Files          63       63              
  Lines       14103    14121      +18     
==========================================
+ Hits        11267    11284      +17     
- Misses       2836     2837       +1     
Flag Coverage Δ
JETLS.jl 79.90% <94.44%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aviatesk
aviatesk merged commit a2c490c into master Aug 29, 2026
23 checks passed
@aviatesk
aviatesk deleted the up-JSJL branch August 29, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant