Fix direct execute calldata parsing (#9)#60
Open
tarrencev wants to merge 1 commit intoavnu-labs:mainfrom
Open
Conversation
* Add version-agnostic raw execute endpoint (#2) * ✨ add version-agnostic raw execute endpoint Add paymaster_executeRawTransaction RPC method that accepts pre-built execute_from_outside calls, making the paymaster agnostic to SNIP-9 versions. * 🎨 fix formatting * ci: disable codecov failure blocking * test: add tests for execute_raw endpoint * Fix duplicate raw execute imports * Use DirectInvoke and dynamic calls parsing * Sync execute_direct endpoint formatting * Simplify direct execute fee estimation
|
@tarrencev is attempting to deploy a commit to the 419labs Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| if last_call.calldata.len() != 3 { | ||
| return Err(Error::InvalidTypedData); | ||
| let calldata = &self.execute_from_outside_call.calldata; | ||
| for calls_len_index in [4usize, 5] { |
Contributor
There was a problem hiding this comment.
I think you could refactor this to make it more Rust-idiomatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Cartridge Controller Execute From Outside schema