Skip to content

Restructure Functional/Unit Tests#94

Merged
richtja merged 1 commit into
avocado-framework:mainfrom
harvey0100:structure
Oct 21, 2025
Merged

Restructure Functional/Unit Tests#94
richtja merged 1 commit into
avocado-framework:mainfrom
harvey0100:structure

Conversation

@harvey0100

@harvey0100 harvey0100 commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Restructure of the Autils test directories, preparation for functional tests being included, and change of metadata files for the test runs.

Summary by CodeRabbit

  • Chores
    • Reorganized internal test reference paths in metadata configuration files to align with updated test directory structure.

Restrucutre of the Autils test directories, preperation for functional
tests being included, change of metadata files for the test runs.

Signed-off-by: Harvey Lynden <hlynden@redhat.com>
@harvey0100 harvey0100 requested a review from richtja October 21, 2025 11:57
@harvey0100 harvey0100 self-assigned this Oct 21, 2025
@coderabbitai

coderabbitai Bot commented Oct 21, 2025

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Test reference paths in multiple metadata YAML files are updated from a flat tests/modules/* structure to a hierarchical structure with tests/unit/modules/* and tests/functional/modules/* subdirectories. No functional or logic changes.

Changes

Cohort / File(s) Change Summary
Metadata test path reorganization (unit)
metadata/archive/ar.yml, metadata/data_structures.yml, metadata/devel/gdb.yml, metadata/devel/output.yml, metadata/file/path.yml
Updated test reference paths from tests/modules/* to tests/unit/modules/*
Metadata test path reorganization (unit + functional)
metadata/network/ports.yml
Updated test paths from tests/modules/network/ports_unit.py and tests/modules/network/ports_functional.py to tests/unit/modules/network/ports.py and tests/functional/modules/network/ports.py

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Restructure Functional/Unit Tests" is directly and comprehensively related to the main change in the pull request. All modifications across the six metadata files involve reorganizing test file paths from a flat tests/modules/... structure to a segregated structure with tests/unit/modules/... and tests/functional/modules/... subdirectories. The title clearly and specifically captures this primary objective, as confirmed by the PR description which states the purpose is to "restructure of the Autils test directories." The title is concise, readable, and sufficiently specific that a developer scanning the repository history would immediately understand the change concerns test directory reorganization.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 719ffa4 and f51066a.

📒 Files selected for processing (6)
  • metadata/archive/ar.yml (1 hunks)
  • metadata/data_structures.yml (1 hunks)
  • metadata/devel/gdb.yml (1 hunks)
  • metadata/devel/output.yml (1 hunks)
  • metadata/file/path.yml (1 hunks)
  • metadata/network/ports.yml (1 hunks)
🔇 Additional comments (6)
metadata/archive/ar.yml (1)

15-15: Verify test file has been moved to the new path.

Confirm that tests/unit/modules/archive/ar.py exists and that the old tests/modules/archive/ar.py path is no longer used.

metadata/devel/output.yml (1)

16-16: Verify test file has been moved to the new path.

Confirm that tests/unit/modules/devel/output.py exists and that the old tests/modules/devel/output.py path is no longer used.

metadata/devel/gdb.yml (1)

14-14: Verify test file has been moved to the new path.

Confirm that tests/unit/modules/devel/gdb.py exists and that the old tests/modules/devel/gdb.py path is no longer used.

metadata/file/path.yml (1)

16-16: Verify test file has been moved to the new path.

Confirm that tests/unit/modules/file/path.py exists and that the old tests/modules/file/path.py path is no longer used.

metadata/data_structures.yml (1)

16-16: Test file migration verified—no action required.

The test file has been successfully relocated to tests/unit/modules/data_structures.py and the old path is no longer present. The metadata reference is accurate.

metadata/network/ports.yml (1)

16-17: Changes verified and correct.

The old test files (ports_unit.py and ports_functional.py) have been removed, and the new consolidated test files are properly populated:

  • tests/unit/modules/network/ports.py (129 lines, contains unit test imports and code)
  • tests/functional/modules/network/ports.py (71 lines, contains functional test content with OS interaction)

The metadata file update accurately reflects the new file structure.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mr-avocado mr-avocado Bot moved this to Review Requested in Default project Oct 21, 2025

@richtja richtja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richtja richtja merged commit 82f4d9b into avocado-framework:main Oct 21, 2025
7 checks passed
@github-project-automation github-project-automation Bot moved this from Review Requested to Done 113 in Default project Oct 21, 2025
@codecov

codecov Bot commented Oct 21, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (c51ee3a) to head (f51066a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main   #94        +/-   ##
==========================================
- Coverage   100.00%     0   -100.00%     
==========================================
  Files            1     0         -1     
  Lines           61     0        -61     
==========================================
- Hits            61     0        -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

harvey0100 pushed a commit to harvey0100/autils that referenced this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done 113

Development

Successfully merging this pull request may close these issues.

2 participants