Skip to content

html: replace deprecated codecs.open with builtin open#6289

Open
harvey0100 wants to merge 1 commit intoavocado-framework:masterfrom
harvey0100:fix-html-deprecated-codecs-open
Open

html: replace deprecated codecs.open with builtin open#6289
harvey0100 wants to merge 1 commit intoavocado-framework:masterfrom
harvey0100:fix-html-deprecated-codecs-open

Conversation

@harvey0100
Copy link
Copy Markdown
Contributor

@harvey0100 harvey0100 commented Mar 23, 2026

codecs.open() is deprecated in favor of the builtin open() with an encoding parameter. This triggers pylint W4902 (deprecated-method) which causes the pre-commit pylint hook to fail for all commits since the check-lint script lints the entire repo.

codecs.open() is deprecated in favor of the builtin open() with an
encoding parameter. This triggers pylint W4902 (deprecated-method)
which causes the pre-commit pylint hook to fail for all commits since
the check-lint script lints the entire repo.

Assisted-By: Cursor-Claude-4-Sonnet
Signed-off-by: Harvey Lynden <hlynden@redhat.com>
@mr-avocado mr-avocado bot moved this to Review Requested in Default project Mar 23, 2026
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the file input/output operations within the HTML plugin by migrating from the deprecated codecs.open() to the standard open() function. This change resolves a persistent pylint warning that was preventing successful linting, ensuring the codebase adheres to current best practices and passes automated checks.

Highlights

  • Deprecation Fix: Replaced the deprecated codecs.open() function with the built-in open() function, utilizing its encoding parameter for file operations.
  • Pylint Warning Resolution: Addressed the pylint W4902 (deprecated-method) warning, which was causing the pre-commit pylint hook to fail across the repository.
  • Code Modernization: Updated file handling logic to align with modern Python practices, improving code maintainability and consistency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly replaces the deprecated codecs.open() with the built-in open() function, specifying the encoding as a keyword argument. The changes are straightforward and correctly applied, removing an unnecessary dependency on the codecs module for this purpose and resolving a pylint warning. The implementation is sound and there are no issues with the changes.

@harvey0100 harvey0100 requested review from richtja March 23, 2026 15:13
@harvey0100 harvey0100 assigned harvey0100 and unassigned richtja Mar 23, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.67%. Comparing base (322254c) to head (d7b2d92).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6289      +/-   ##
==========================================
- Coverage   73.67%   73.67%   -0.01%     
==========================================
  Files         206      206              
  Lines       22634    22633       -1     
==========================================
- Hits        16676    16674       -2     
- Misses       5958     5959       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review Requested

Development

Successfully merging this pull request may close these issues.

2 participants