Skip to content
This repository was archived by the owner on Sep 2, 2018. It is now read-only.

Conversation

@rjordans
Copy link

Partially fixes #27 by updating load/store tests to match with currently generated output.

@dylanmckay
Copy link
Member

Are these registers consistent with the AVR C calling convention?

@rjordans
Copy link
Author

I think they are but I'll double check. I did already spot one problem with my widened tests, the ldd operation is apparently only available for the Y and Z registers so that should be reflected in the tests. Otherwise it looks OK I think, most tests don't actually check on the calling convention here anyway. I'll check the calling convention correctness and store tests tomorrow.

@dylanmckay
Copy link
Member

Once you check, tell me and I'd be happy to merge :)

Nice work!

@rjordans
Copy link
Author

Hi Dylan,

Sorry for the long delay but I checked the tests now. I've removed the X register from the option list for the load/store with displacement checks as those operations don't exist in the AVR architecture.

Besides that everything seems to be OK now on my system.

Cheers,
Roel

@rjordans
Copy link
Author

Oh, and I've also checked the calling convention which seems to be consistent as well. Some of the address registers do get moved from the input argument into other registers which was why the tests were failing. These new tests don't check for the added moves and will assume that the calling convention is checked elsewhere.

@dylanmckay
Copy link
Member

Nice work @rjordans, merging now :)

@dylanmckay dylanmckay merged commit 0b196f9 into avr-llvm:avr-support May 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants