Skip to content

MAINTENANCE: Revert workflow_run trigger for AI review#472

Merged
awinogradov merged 1 commit into
mainfrom
maintenance-revert-code-review-workflow-run
Jul 22, 2026
Merged

MAINTENANCE: Revert workflow_run trigger for AI review#472
awinogradov merged 1 commit into
mainfrom
maintenance-revert-code-review-workflow-run

Conversation

@awinogradov

Copy link
Copy Markdown
Owner

Reverts #471 (the on: workflow_run migration of AI code review).

Why revert: under workflow_run, a job's status attaches to the default-branch commit, not the PR head SHA — so the visible ai-review check disappears from the PR and it can't be a required status check without extra Checks-API work. workflow_run also fires on every completion of the gate workflow repo-wide (every PR, every push-to-main, every schedule), spinning up many review runs that mostly skip. The review verdict itself still posts (as a pulls.createReview), so nothing was strictly broken, but losing the on-PR check and the run proliferation are regressions.

Restoring the pull_request trigger brings back the visible ai-review check. The original motivation for #471 — the preflight poll racing a repo's CI wall clock and flapping red on a 600s timeout — is better addressed by the consuming repo reducing its gate wall clock (already done downstream), so pull_request + preflight comfortably fits the budget again.

This also reverts the sender-skip scoping from #471 (a bot chore commit could suppress review). A cleaner redo — running code-review as a project-level PR-gate job ordered via needs: (review after CI, as a normal pull_request-context check, no polling and no workflow_run proliferation) — is tracked separately and will restore that fix properly.

Exactly restores the pre-#471 code-review.yml and action.yml (verified: empty diff vs the commit before #471).

Reverts the workflow_run migration: under workflow_run the ai-review job status
attaches to the default branch, not the PR head SHA, so the visible ai-review
check disappears from the PR and runs proliferate across every PR-gate
completion repo-wide. The verdict still posts as a review, but the on-PR check
is lost. Restore the pull_request trigger; the preflight timeout is mitigated by
the consuming repo's own CI wall-clock reduction. A cleaner redo (code-review as
a project-level PR-gate job ordered via needs) is tracked separately.

This reverts commit 504b161.
@symbiot-bot symbiot-bot added the code-assistants/code-review-action Auto-applied: PR touches code-assistants/code-review-action label Jul 22, 2026
@symbiot-bot
symbiot-bot self-requested a review July 22, 2026 20:26

@symbiot-bot symbiot-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @awinogradov!


Review run summary 🤖
Metric Value
Mode review
Model claude-sonnet-5
Model time 64.9s
Tool round-trips 13
Assistant turns 14
Tokens in / out 699202 / 3883
Cache read / write 617104 / 82081
Cost (USD) $0.55

@awinogradov
awinogradov merged commit 5675fcc into main Jul 22, 2026
9 checks passed
@awinogradov
awinogradov deleted the maintenance-revert-code-review-workflow-run branch July 22, 2026 20:30
symbiot-bot added a commit that referenced this pull request Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-assistants/code-review-action Auto-applied: PR touches code-assistants/code-review-action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants