fix: add maxDelay to prevent exponential backoff in waiters #839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A (new issue discovered)
Description of changes:
Problem
The SDK v3 upgrade (commits a15de3c, b5c6c3f) added
minDelaybut did not addmaxDelayto the waiter options. WithoutmaxDelay, the AWS SDK defaults to 120 seconds, causing exponential backoff between polls:This means even if the ECS service becomes stable quickly, the action may wait up to 2 minutes before the next poll detects it.
Solution
Added
maxDelay: WAIT_DEFAULT_DELAY_SEC(15 seconds) to all three waiters:waitUntilTasksStoppedwaitUntilServicesStablewaitUntilDeploymentSuccessfulThis ensures consistent 15-second polling intervals without exponential backoff.
Testing
dist/index.jswithnpm run packageBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.