Skip to content

fix(logging): Fixes issue of logging category not initializing properly using gen2 config #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025

Conversation

mattcreaser
Copy link
Member

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: #3019

Description of changes:
When using a Gen2 config the logging category was not properly setting it's state because of a missing call to super.configure. This doesn't impact the normal usage of the category but does cause some category-level APIs (such as getPlugin) to fail.

How did you test these changes?

  • Unit tests

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner April 15, 2025 15:29
@mattcreaser mattcreaser enabled auto-merge (squash) April 30, 2025 18:18
@mattcreaser mattcreaser merged commit 09e5693 into main Apr 30, 2025
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/cloud-watch-configure branch April 30, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants