Skip to content

chore(auth): Fix failing integration tests #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025

Conversation

mattcreaser
Copy link
Member

@mattcreaser mattcreaser commented Apr 25, 2025

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Fix states getting missed by sending the event in onStart on the flow.

How did you test these changes?

  • The Integration test GraphQLInstrumentationTest fails 80% of the time when running on my Pixel 9 Pro from main, but does not fail after these changes.
  • Removed the instrumentation tests for the core module since they were continuously failing and offer no real benefit

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested a review from a team as a code owner April 25, 2025 14:34
tylerjroach
tylerjroach previously approved these changes Apr 25, 2025
@mattcreaser mattcreaser force-pushed the mattcreaser/usecase-fetch-auth-session-fix branch from 5aa2678 to 6c38639 Compare April 25, 2025 18:20
@mattcreaser mattcreaser changed the title fix(auth): Refactor FetchAuthSessionUseCase for state machine race condition chore(auth): Fix failing integration tests Apr 25, 2025
@mattcreaser mattcreaser enabled auto-merge (squash) April 28, 2025 14:18
@mattcreaser mattcreaser merged commit 4cf9f34 into main Apr 28, 2025
3 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/usecase-fetch-auth-session-fix branch April 28, 2025 16:48
mattcreaser added a commit that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants