fix: Handle uncaught exception in create-amplify #2828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Issue number, if available: #825
Changes
This change is similar to #2364 but the original change didn't fully fix the issue. Whilt it adds the error handler, it didn't change the try/catch loop and the error was being thrown by the
getProjectRoot()
. So modify the try block to surround all of the code that needs to close gracefully.Corresponding docs PR, if applicable: N/A
Validation
CLI output:
I triggered a SIGINT and the command stopped gracefully.
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.