Skip to content

fix: Handle uncaught exception in create-amplify #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 16, 2025

Conversation

vincetran
Copy link
Member

Problem

Issue number, if available: #825

Changes

This change is similar to #2364 but the original change didn't fully fix the issue. Whilt it adds the error handler, it didn't change the try/catch loop and the error was being thrown by the getProjectRoot(). So modify the try block to surround all of the code that needs to close gracefully.

Corresponding docs PR, if applicable: N/A

Validation

CLI output:

❯ npx create-amplify
? Where should we create your project? (.)

╭─  ~/Development/backend/test-projects/test1 │ vincetran/crash-handling *
╰─

I triggered a SIGINT and the command stopped gracefully.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested review from a team as code owners May 23, 2025 22:08
Copy link

changeset-bot bot commented May 23, 2025

🦋 Changeset detected

Latest commit: 810a25f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
create-amplify Patch
@aws-amplify/cli-core Minor
@aws-amplify/backend-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sobolk sobolk merged commit 995b335 into aws-amplify:main Jun 16, 2025
52 checks passed
sobolk added a commit that referenced this pull request Jun 16, 2025
sobolk added a commit that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants