Skip to content

feat(rtn-passkeys): modify existing implementation - 2 #14391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: feat/rtn-passkeys/1-add-new-package
Choose a base branch
from

Conversation

jjarvisp
Copy link
Member

@jjarvisp jjarvisp commented May 17, 2025

Description of changes

The purpose of this PR is modify the existing auth and react-native packages to support the new rtn-passkeys package.

  • Minor refactoring of existing client/utils/passkey folder and file structure.
  • Adds internal util for detecting native errors.
  • Modifies error handlers to support native error structure.
  • Adds unit tests for native code paths.
  • Replace existing unsupported APIs with actual implementation.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jjarvisp jjarvisp changed the title feat: modify existing implementation feat(rtn-passkeys): modify existing implementation May 17, 2025
@jjarvisp jjarvisp changed the title feat(rtn-passkeys): modify existing implementation feat(rtn-passkeys): modify existing implementation - 2 May 17, 2025
@jjarvisp jjarvisp force-pushed the feat/rtn-passkeys/1-add-new-package branch from c3efbfc to 773f40b Compare May 17, 2025 23:31
@jjarvisp jjarvisp force-pushed the feat/rtn-passkeys/2-modify-existing-impl branch from abd18da to 8065ea4 Compare May 17, 2025 23:32
@jjarvisp jjarvisp marked this pull request as ready for review May 19, 2025 20:52
@jjarvisp jjarvisp force-pushed the feat/rtn-passkeys/2-modify-existing-impl branch from 0d354c2 to 069893e Compare May 21, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants