Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo #4156

Merged
merged 6 commits into from
Oct 9, 2019
Merged

Fixed typo #4156

merged 6 commits into from
Oct 9, 2019

Conversation

dabit3
Copy link
Contributor

@dabit3 dabit3 commented Oct 9, 2019

Removed additional Amplify in CONTRIBUTING.md doc.

@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #4156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4156   +/-   ##
=======================================
  Coverage   70.68%   70.68%           
=======================================
  Files         168      168           
  Lines        9728     9728           
  Branches     2020     2020           
=======================================
  Hits         6876     6876           
  Misses       2493     2493           
  Partials      359      359

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a1055a...74103a3. Read the comment docs.

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🌮

@sammartinez sammartinez merged commit e6f1bb3 into aws-amplify:master Oct 9, 2019
Amplifiyer pushed a commit to Amplifiyer/amplify-js that referenced this pull request Oct 14, 2019
* disabled autocomplete when resetting password for new password field

* added local development resources to contributing

* fixed typo in CONTRIBUTING doc, aws-amplify#3990
Amplifiyer added a commit that referenced this pull request Oct 17, 2019
* Build ES6 Modules along with CJS Modules
* Upgrade Typescript to 3.5
* Upgrade Webpack to 4
* Upgrade Jest to 24
[Delivers #168385455]

* Removing unused variable from build scripts

* Fix signout component being undefined

* Fix PR comments

* Apply Prettier formatting

* Merge branch 'master' of github.com:aws-amplify/amplify-js into modularization-merge

* Fix tests that were failing after merge from master

* Revert docs and other directories impacted by prettier

* Update repository and homepage urls for all packages

* Add diagnostic information to build script in event of failures

* Revert formatter command as library now used Prettier with pre-commit hook

* Adding unit test for pubsub desconnection issue

* Fixing websocket disconnect issue on MqttProvider

* Update stale.yml

* fix: lerna linking for unstable and beta

* fix(amazon-cognito-identity-js): linting config (#4097)

* partially resolves linting issues in cognito sdk

* removes no-cap lint change

* using prettier to extend eslint in cognito sdk

* removing newline

* using airbnb lint config as well as prettier

* Fix failing pubsub tests because of jest upgrade

* Fix issue SignOut component being undefined

* Apply suggestions from code review

Co-Authored-By: Manuel Iglesias <[email protected]>

* Made mock window worker in angular tests more explicit

* Fix failing pubsub tests because of jest upgrade

* fix(@aws-amplify/core): removed unused variables (#3926)

* Added link to docs for local development to CONTRIBUTING (#3990)

* disabled autocomplete when resetting password for new password field

* added local development resources to contributing

* Fixed typo (#4156)

* disabled autocomplete when resetting password for new password field

* added local development resources to contributing

* fixed typo in CONTRIBUTING doc, #3990

* fix(@aws-amplify/api) Adding x-amz-user-agent for AppSync calls

* Adding x-amz-user-agent for appsync calls

* Fixing unit test

* chore(release): Publish [ci skip]

 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]

* Publish

 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]

* chore(release): Publish [ci skip]

 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]

* fix(#4001) (#4131)

* fix picker parent style (#4135)

* Reduce threads to 1 while running jest tests as Circle CI constantly running out of memory

* Remove unnecessary async/awaits in pubsub tests

* Add Credentials mock explicitly on two tests that are failing only in circle ci

* Move spyon in beforeEach
computationalcore pushed a commit to computationalcore/amplify-js that referenced this pull request Feb 4, 2020
* Build ES6 Modules along with CJS Modules
* Upgrade Typescript to 3.5
* Upgrade Webpack to 4
* Upgrade Jest to 24
[Delivers #168385455]

* Removing unused variable from build scripts

* Fix signout component being undefined

* Fix PR comments

* Apply Prettier formatting

* Merge branch 'master' of github.com:aws-amplify/amplify-js into modularization-merge

* Fix tests that were failing after merge from master

* Revert docs and other directories impacted by prettier

* Update repository and homepage urls for all packages

* Add diagnostic information to build script in event of failures

* Revert formatter command as library now used Prettier with pre-commit hook

* Adding unit test for pubsub desconnection issue

* Fixing websocket disconnect issue on MqttProvider

* Update stale.yml

* fix: lerna linking for unstable and beta

* fix(amazon-cognito-identity-js): linting config (aws-amplify#4097)

* partially resolves linting issues in cognito sdk

* removes no-cap lint change

* using prettier to extend eslint in cognito sdk

* removing newline

* using airbnb lint config as well as prettier

* Fix failing pubsub tests because of jest upgrade

* Fix issue SignOut component being undefined

* Apply suggestions from code review

Co-Authored-By: Manuel Iglesias <[email protected]>

* Made mock window worker in angular tests more explicit

* Fix failing pubsub tests because of jest upgrade

* fix(@aws-amplify/core): removed unused variables (aws-amplify#3926)

* Added link to docs for local development to CONTRIBUTING (aws-amplify#3990)

* disabled autocomplete when resetting password for new password field

* added local development resources to contributing

* Fixed typo (aws-amplify#4156)

* disabled autocomplete when resetting password for new password field

* added local development resources to contributing

* fixed typo in CONTRIBUTING doc, aws-amplify#3990

* fix(@aws-amplify/api) Adding x-amz-user-agent for AppSync calls

* Adding x-amz-user-agent for appsync calls

* Fixing unit test

* chore(release): Publish [ci skip]

 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]

* Publish

 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]

* chore(release): Publish [ci skip]

 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]

* fix(aws-amplify#4001) (aws-amplify#4131)

* fix picker parent style (aws-amplify#4135)

* Reduce threads to 1 while running jest tests as Circle CI constantly running out of memory

* Remove unnecessary async/awaits in pubsub tests

* Add Credentials mock explicitly on two tests that are failing only in circle ci

* Move spyon in beforeEach
rasfra pushed a commit to epidemicsound/amplify-js that referenced this pull request Mar 11, 2020
* Build ES6 Modules along with CJS Modules
* Upgrade Typescript to 3.5
* Upgrade Webpack to 4
* Upgrade Jest to 24
[Delivers #168385455]

* Removing unused variable from build scripts

* Fix signout component being undefined

* Fix PR comments

* Apply Prettier formatting

* Merge branch 'master' of github.com:aws-amplify/amplify-js into modularization-merge

* Fix tests that were failing after merge from master

* Revert docs and other directories impacted by prettier

* Update repository and homepage urls for all packages

* Add diagnostic information to build script in event of failures

* Revert formatter command as library now used Prettier with pre-commit hook

* Adding unit test for pubsub desconnection issue

* Fixing websocket disconnect issue on MqttProvider

* Update stale.yml

* fix: lerna linking for unstable and beta

* fix(amazon-cognito-identity-js): linting config (aws-amplify#4097)

* partially resolves linting issues in cognito sdk

* removes no-cap lint change

* using prettier to extend eslint in cognito sdk

* removing newline

* using airbnb lint config as well as prettier

* Fix failing pubsub tests because of jest upgrade

* Fix issue SignOut component being undefined

* Apply suggestions from code review

Co-Authored-By: Manuel Iglesias <[email protected]>

* Made mock window worker in angular tests more explicit

* Fix failing pubsub tests because of jest upgrade

* fix(@aws-amplify/core): removed unused variables (aws-amplify#3926)

* Added link to docs for local development to CONTRIBUTING (aws-amplify#3990)

* disabled autocomplete when resetting password for new password field

* added local development resources to contributing

* Fixed typo (aws-amplify#4156)

* disabled autocomplete when resetting password for new password field

* added local development resources to contributing

* fixed typo in CONTRIBUTING doc, aws-amplify#3990

* fix(@aws-amplify/api) Adding x-amz-user-agent for AppSync calls

* Adding x-amz-user-agent for appsync calls

* Fixing unit test

* chore(release): Publish [ci skip]

 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]

* Publish

 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]

* chore(release): Publish [ci skip]

 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]
 - @aws-amplify/[email protected]

* fix(aws-amplify#4001) (aws-amplify#4131)

* fix picker parent style (aws-amplify#4135)

* Reduce threads to 1 while running jest tests as Circle CI constantly running out of memory

* Remove unnecessary async/awaits in pubsub tests

* Add Credentials mock explicitly on two tests that are failing only in circle ci

* Move spyon in beforeEach
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants