feat(predictions): No-Light/FaceMovementOnly challenge support #3622
+598
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisabhash
force-pushed
the
feat/no-light-support
branch
from
22e02fa to
41505e0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3622 +/- ##
==========================================
+ Coverage 67.69% 67.75% +0.05%
==========================================
Files 1128 1131 +3
Lines 52468 52603 +135
==========================================
+ Hits 35519 35639 +120
- Misses 16949 16964 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thisisabhash
force-pushed
the
feat/no-light-support
branch
from
41505e0 to
1a5386d
Compare
thisisabhash
force-pushed
the
feat/no-light-support
branch
from
1a5386d to
4815461
Compare
API Breakage Report✅ No Public API Breaking Change detected |
…ort (#3617) * feat(predictions): add public definitions for no light challenge support * Add missing files * fix swiftlint issue * feat(predictions): add implementation for no light support (#3618) * feat(predictions): add implementation for no light support * fix swiftlint issue * address review comments * address review comments * address review comments
* chore(predictions): add attempt count changes and unit tests * remove test url * Add coding keys for Challenge object
thisisabhash
force-pushed
the
feat/no-light-support
branch
from
614be62 to
ae1d96a
Compare
harsh62
reviewed
Jun 20, 2025
|
|
||
| @_spi(PredictionsFaceLiveness) | ||
| public struct Challenge: Codable { | ||
| public let version: String |
There was a problem hiding this comment.
Can this be an enum instead? Easy to compare and switch over if need.
There was a problem hiding this comment.
I added this suggestion based on how the following was built:
public static let supportedChallenges: [Challenge] = [
Challenge(version: "2.0.0", type: .faceMovementAndLightChallenge),
Challenge(version: "1.0.0", type: .faceMovementChallenge)
]
Comment on lines
-13
to
+19
| public let colorChallenge: ColorChallenge | ||
| public let colorChallenge: ColorChallenge? | ||
| public let ovalMatchChallenge: OvalMatchChallenge | ||
|
|
||
| public init(colorChallenge: ColorChallenge, ovalMatchChallenge: OvalMatchChallenge) { | ||
| public init( | ||
| colorChallenge: ColorChallenge? = nil, | ||
| ovalMatchChallenge: OvalMatchChallenge | ||
| ) { |
There was a problem hiding this comment.
nit: My personal opinion would be to avoid optionals as much as we can and use enums/protocols instead. Keeps thing simple and no null guessing game that we need to play.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
None
Description
Changes for No-Light/FaceMovementOnly challenge support
General Checklist
Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.