Skip to content

Angular Authenticator Flow Update #6778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akilisosa
Copy link

@akilisosa akilisosa commented Jan 13, 2024

Description of changes:

The angular part of the documentation for setting up the Amplify Authenticator Module / prebuilt authenticator component was updated to reflect a valid way to get the component rendered in the browser without issues.

The current instructions overlook some additional steps, to import the .json file into your component.
The current instructions a place the configuration of amplify and the module import in the the app component. The configuration step should be located in main.ts file, and the import should be done in the app.module . This follows the pattern that was set in the previous documents.
The current instructions also ask that we import the styles into a style.css file which did not work for me.

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@josefaidt
Copy link
Contributor

Hey @akilisosa 👋 thanks for raising this and apologies for the delay! Would you mind resolving the conflicts on this one? There have been a few updates since this was filed for the client configuration file, namely the change from amplifyconfiguration.json -> amplify_outputs.json

@akilisosa
Copy link
Author

@josefaidt Thanks I will have to look into it. I remember raising it and then seeing the documentation change to something very similar to this request. I might have to abandon this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants