Skip to content

Add ServerlessCacheSnapshot to elasticache #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2025
Merged

Add ServerlessCacheSnapshot to elasticache #182

merged 3 commits into from
Sep 8, 2025

Conversation

ack-bot
Copy link
Collaborator

@ack-bot ack-bot commented Aug 13, 2025

ACK Agent changes adding ServerlessCacheSnapshot to elasticache-controller

@ack-prow ack-prow bot requested review from a-hilaly and jlbutler August 13, 2025 20:09
@rushmash91 rushmash91 force-pushed the elasticache-add-ServerlessCacheSnapshot branch 3 times, most recently from 704f743 to 1c1b761 Compare August 27, 2025 00:33
@rushmash91 rushmash91 force-pushed the elasticache-add-ServerlessCacheSnapshot branch from 1c1b761 to ee92743 Compare August 27, 2025 01:09
knottnt
knottnt reviewed Sep 4, 2025
View reviewed changes
@rushmash91 rushmash91 force-pushed the elasticache-add-ServerlessCacheSnapshot branch from e802cc4 to 64b9535 Compare September 5, 2025 18:54
@rushmash91 rushmash91 force-pushed the elasticache-add-ServerlessCacheSnapshot branch from 64b9535 to 5a40e0a Compare September 5, 2025 23:01
@ack-prow ack-prow bot added the approved label Sep 5, 2025
@rushmash91
Copy link
Member

/retest

@ack-prow ACK Prow
Copy link

ack-prow bot commented Sep 5, 2025 •
edited
Loading

@ack-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
elasticache-verify-attribution 5a40e0a link false /test elasticache-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knottnt
Copy link

knottnt commented Sep 8, 2025

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2025
@ack-prow ACK Prow
Copy link

ack-prow bot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ack-bot, knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 15b7e88 into aws-controllers-k8s:main Sep 8, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rushmash91 rushmash91 rushmash91 left review comments

@knottnt knottnt knottnt approved these changes

@a-hilaly a-hilaly Awaiting requested review from a-hilaly

@jlbutler jlbutler Awaiting requested review from jlbutler

Assignees

@knottnt knottnt

Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ack-bot @rushmash91 @knottnt