Skip to content

feat: Support ClusterV2 as ServerlessCluster #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented May 15, 2025

Issue #2492

Description of changes:

  • Add ClusterV2 support
  • test crud and tags

Extra changes to Cluster resource:

  • remove unnecessary fmt.Sprintf
  • ensure SetSynced is applied to the resource that is returned (previously was discarded)
  • remove commented Tag tests!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from a-hilaly and knottnt May 15, 2025 00:05
@ack-prow ack-prow bot added the approved label May 15, 2025
@michaelhtm michaelhtm force-pushed the feat/addclusterv2support branch 3 times, most recently from 0cf2bef to 8ae1ec6 Compare May 15, 2025 17:00
Copy link

@knottnt knottnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Could you add a bit more detail to the PR description though? This PR does a bit more than test CRUD e2e.

@knottnt
Copy link

knottnt commented Jun 10, 2025

@michaelhtm It looks like this PR has some conflicts.

@michaelhtm michaelhtm force-pushed the feat/addclusterv2support branch from 8ae1ec6 to dc51a26 Compare June 10, 2025 17:10
Copy link

ack-prow bot commented Jun 10, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kafka-verify-attribution dc51a26 link false /test kafka-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knottnt
Copy link

knottnt commented Jun 12, 2025

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
Copy link

ack-prow bot commented Jun 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knottnt, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 039f28f into aws-controllers-k8s:main Jun 12, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants