Skip to content

tests: Ready condition rename for sns-controller #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tests: Ready condition rename for sns-controller #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbe0754
Ready condition migration for sns controller
Sep 25, 2025
132db83
Merge branch 'main' into update-ready-condition-sns-20250925061036
a-hilaly Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions apis/v1alpha1/platform_endpoint.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions config/crd/bases/sns.services.k8s.aws_platformendpoints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ spec:
description: PlatformEndpointSpec defines the desired state of PlatformEndpoint.
properties:
customUserData:
description: |-
Arbitrary user data to associate with the endpoint. Amazon SNS does not use
this data. The data must be in UTF-8 format and less than 2KB.
type: string
enabled:
type: string
Expand All @@ -52,13 +49,6 @@ spec:
create a an endpoint.
type: string
token:
description: |-
Unique identifier created by the notification service for an app on a device.
The specific name for Token will vary, depending on which notification service
is being used. For example, when using APNS as the notification service,
you need the device token. Alternatively, when using GCM (Firebase Cloud
Messaging) or ADM, the device token equivalent is called the registration
ID.
type: string
required:
- platformApplicationARN
Expand Down
2 changes: 2 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,5 @@ require (
sigs.k8s.io/structured-merge-diff/v4 v4.4.2 // indirect
sigs.k8s.io/yaml v1.4.0 // indirect
)

replace github.com/aws-controllers-k8s/runtime => github.com/gustavodiaz7722/ack-runtime v0.57.0
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ github.com/aws-controllers-k8s/iam-controller v1.1.1 h1:O6arh7DNlQF26MEKzgA2/kBE
github.com/aws-controllers-k8s/iam-controller v1.1.1/go.mod h1:2+ARwRpazTq5MErjMz0MpXHhtAzRfNtY56Uj0gvu9vE=
github.com/aws-controllers-k8s/kms-controller v1.0.2 h1:v8nh/oaX/U6spCwBDaWyem7XXpzoP/MnkJyEjNOZN9s=
github.com/aws-controllers-k8s/kms-controller v1.0.2/go.mod h1:BeoijsyGjJ9G5VcDjpFdxBW0IxaeKXYX497XmUJiPSQ=
github.com/aws-controllers-k8s/runtime v0.52.0 h1:Q5UIAn6SSBr60t/DiU/zr6NLBlUuK2AG3yy2ma/9gDU=
github.com/aws-controllers-k8s/runtime v0.52.0/go.mod h1:OkUJN+Ds799JLYZsMJrO2vDJ4snxUeHK2MgrQHbU+Qc=
github.com/aws/aws-sdk-go v1.49.0 h1:g9BkW1fo9GqKfwg2+zCD+TW/D36Ux+vtfJ8guF4AYmY=
github.com/aws/aws-sdk-go v1.49.0/go.mod h1:LF8svs817+Nz+DmiMQKTO3ubZ/6IaTpq3TjupRn3Eqk=
github.com/aws/aws-sdk-go-v2 v1.34.0 h1:9iyL+cjifckRGEVpRKZP3eIxVlL06Qk1Tk13vreaVQU=
Expand Down Expand Up @@ -88,6 +86,8 @@ github.com/google/pprof v0.0.0-20241029153458-d1b30febd7db h1:097atOisP2aRj7vFgY
github.com/google/pprof v0.0.0-20241029153458-d1b30febd7db/go.mod h1:vavhavw2zAxS5dIdcRluK6cSGGPlZynqzFM8NdvU144=
github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/gustavodiaz7722/ack-runtime v0.57.0 h1:85zJyvdPpzOTaWE0icljJcMRf0qlP0oWdOT05hMZ6Z0=
github.com/gustavodiaz7722/ack-runtime v0.57.0/go.mod h1:OkUJN+Ds799JLYZsMJrO2vDJ4snxUeHK2MgrQHbU+Qc=
github.com/itchyny/gojq v0.12.6 h1:VjaFn59Em2wTxDNGcrRkDK9ZHMNa8IksOgL13sLL4d0=
github.com/itchyny/gojq v0.12.6/go.mod h1:ZHrkfu7A+RbZLy5J1/JKpS4poEqrzItSTGDItqsfP0A=
github.com/itchyny/timefmt-go v0.1.3 h1:7M3LGVDsqcd0VZH2U+x393obrzZisp7C0uEe921iRkU=
Expand Down
10 changes: 0 additions & 10 deletions helm/crds/sns.services.k8s.aws_platformendpoints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ spec:
description: PlatformEndpointSpec defines the desired state of PlatformEndpoint.
properties:
customUserData:
description: |-
Arbitrary user data to associate with the endpoint. Amazon SNS does not use
this data. The data must be in UTF-8 format and less than 2KB.
type: string
enabled:
type: string
Expand All @@ -52,13 +49,6 @@ spec:
create a an endpoint.
type: string
token:
description: |-
Unique identifier created by the notification service for an app on a device.
The specific name for Token will vary, depending on which notification service
is being used. For example, when using APNS as the notification service,
you need the device token. Alternatively, when using GCM (Firebase Cloud
Messaging) or ADM, the device token equivalent is called the registration
ID.
type: string
required:
- platformApplicationARN
Expand Down
27 changes: 15 additions & 12 deletions pkg/resource/platform_application/references.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions pkg/resource/subscription/references.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 15 additions & 12 deletions pkg/resource/topic/references.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion test/e2e/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
acktest @ git+https://github.com/aws-controllers-k8s/test-infra.git@38ce32256cc2552ab54e190cc8a8618e93af9e0c
acktest @ git+https://github.com/gustavodiaz7722/ack-test-infra.git@4a5c296da0fe386eadf95c242591ae4724cd0428
2 changes: 1 addition & 1 deletion test/e2e/tests/test_subscription.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def test_crud(self, subscription_sqs):

subscription.wait_until_exists(sub_arn)

condition.assert_synced(sub_ref)
condition.assert_ready(sub_ref)

# Before we update the Topic CR below, let's check to see that the
# DisplayName field in the CR is still what we set in the original
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/tests/test_topic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class TestTopic:
def test_crud(self, simple_topic):
ref, res = simple_topic

condition.assert_synced(ref)
condition.assert_ready(ref)

# Before we update the Topic CR below, let's check to see that the
# DisplayName field in the CR is still what we set in the original
Expand Down Expand Up @@ -180,7 +180,7 @@ def test_crud(self, simple_topic):
def test_crud_fifo(self, fifo_topic):
ref, res = fifo_topic

condition.assert_synced(ref)
condition.assert_ready(ref)

# Before we update the Topic CR below, let's check to see that the
# DisplayName field in the CR is still what we set in the original
Expand Down