generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 186
feat: remove baseUrl from TypeScript configurations for future compiler compatibility #4925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er compatibility - Remove baseUrl from all tsconfig.json files (not supported by native TypeScript compiler) - Fix import paths in layers/bin/layers.ts to use relative imports with .js extensions - Prepares codebase for potential future adoption of @typescript/native-preview - Maintains full compatibility with current TypeScript compiler - All builds continue to work as expected
bd304b3 to
9767057
Compare
|
Contributor
Author
|
Re-run the test a second time on top of the retry, all green: https://github.com/aws-powertools/powertools-lambda-typescript/actions/runs/20763482582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Summary
Changes
Remove the
baseUrl: "."configuration from all TypeScript configuration files across the monorepo and update affected import paths to prepare for potential future adoption of Microsoft's native TypeScript compiler.This change removes technical debt by eliminating an unused configuration option while positioning the codebase for potential future performance improvements. During experimentation with Microsoft's
@typescript/native-previewcompiler, we discovered significant performance gains (5-6x faster local builds, 33% faster CI builds) but found that the native compiler doesn't supportbaseUrl. This preparation work ensures compatibility when the native compiler becomes stable.Changes made:
baseUrl: "."from all tsconfig.json and tsconfig.cjs.json files (22+ files)layers/bin/layers.tsto use relative imports with.jsextensionsIssue number: closes #4924
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.