Skip to content

Extract example for static sites from single page applications example #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thomasturrell
Copy link
Contributor

@thomasturrell thomasturrell commented Nov 6, 2021

Issue #, if available: n/a

Description of changes: Static sites and single page web applications typically have different requirements. Static sites tend to have have an index.html file for each folder where as single page applications only have a single index.html in the root. Single page application typically use a client router to handle the routes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thomasturrell thomasturrell force-pushed the main branch 3 times, most recently from 5056adc to ab841be Compare November 7, 2021 14:24
@thomasturrell
Copy link
Contributor Author

thomasturrell commented Nov 7, 2021

I believe that the duplication in the test is a pragmatic solution because there are links to the existing files. Ideally the structure would be changes so that there was only one set of tests.

@dbrown-git I would appreciate your thoughts. I am happy to further explain my rational for this pull request if it is not clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant