-
Notifications
You must be signed in to change notification settings - Fork 133
Feat/ddp mlflow #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/ddp mlflow #655
Conversation
self.epochs_run = 0 | ||
self.snapshot_path = snapshot_path | ||
self.use_mlflow = use_mlflow | ||
self.tracking_uri = tracking_uri if tracking_uri else f"file://{os.environ['HOME']}/mlruns" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test case is already compatible with local/remote tracking server.
@KeitaW , to showcase MLflow, shouldn't we use the SageMaker Managed MLflow as described here https://docs.aws.amazon.com/sagemaker/latest/dg/mlflow-track-experiments.html |
Working on the compatibility with Managed MLflow |
Thanks for testing. |
Ok, then let's add this to |
Issue #, if available:
Description of changes:
This PR makes ddp test case compatible with both CPU and GPU + add MLFlow support (local tracking by default with optional remote tracking server option).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.