Skip to content

Conversation

ajpaws
Copy link
Collaborator

@ajpaws ajpaws commented Jan 22, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

cluster_metadata = eksclient.describe_cluster(name=resources.cluster)
cluster_version = cluster_metadata["cluster"]["version"]

if cluster_version == current_eks_version:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make this more dynamic? As soon as 1.25 comes out this will be stale and need to be updated. The Best Practices say to use 1.24 or above. https://aws.github.io/aws-eks-best-practices/scalability/docs/control-plane/#use-eks-124-or-above so can we just check if current_version >= 1.24"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants