Migrate S3 clients to AWS SDK Go V2#4564
Merged
Merged
Conversation
7de5ae6 to
5e4f26e
Compare
e6b29b9 to
39ace36
Compare
644de0c to
9dd8fad
Compare
97786b1 to
b6c0945
Compare
05e2de2 to
5778ca7
Compare
mye956
commented
Apr 25, 2025
mye956
commented
Apr 25, 2025
960e5f9 to
78e1565
Compare
ShelbyZ
previously approved these changes
Apr 25, 2025
TheanLim
reviewed
Apr 28, 2025
TheanLim
reviewed
Apr 28, 2025
TheanLim
reviewed
Apr 28, 2025
fixing mocks and tests fixing more unit tests testing with including the config opts as a list of funcs changes for testing, reminder to remove/revert this commit Revert "changes for testing, reminder to remove/revert this commit" This reverts commit 265ed57.
TheanLim
approved these changes
Apr 28, 2025
ShelbyZ
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR will migrate the S3 clients implementations and corresponding code paths from AWS SDK Go V1 to AWS SDK Go V2.
Implementation details
LoadDefaultConfigfromNewConfigas part of V2 migration (ref) increateAWSConfig()s3.NewFromConfig()to create the S3 clientNewDownloaderfromNewDownloaderWithClientforS3ManagerClientS3ManagerClientto now useDownload(ctx context.Context, w io.WriterAt, input *s3.GetObjectInput, options ...func(*s3manager.Downloader))fromDownloadWithContext()GetObject()ofS3Clientinterfaceaws.*Valuetoaws.To*updatesTesting
Launched a task on a FIPs-enabled host in us-west-2
Environment variables within the container
Launched a task on a FIPs-enabled host in a non-supported region ()
Environment variables within the container
Tested using dualstack subnet and confirmed the behavior remained the same
New tests cover the changes: yes
Description for the changelog
Enhancement - Migrate S3 clients to AWS SDK Go V2
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.