IPv6-only support for awslogs logging driver#4577
Merged
Merged
Conversation
xxx0624
reviewed
Apr 18, 2025
prateekchaudhry
previously approved these changes
Apr 18, 2025
TheanLim
previously approved these changes
Apr 18, 2025
TheanLim
approved these changes
Apr 18, 2025
prateekchaudhry
approved these changes
Apr 18, 2025
timj-hh
pushed a commit
to timj-hh/amazon-ecs-agent
that referenced
this pull request
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For supporting awslogs driver in IPv6-only environments, the logging driver needs to consume dual stack CloudWatch Logs endpoints. However, awslogs logging driver in docker does not support enabling dual stack CloudWatch Logs endpoint. To workaround this limitation, this change makes Agent resolve the dual stack endpoint for the logging region and set it as
awslogs-endpointoption in the logging driver configuration.In the long term we will update awslogs driver in Docker to support dual stack endpoints so that Agent does not have to resolve the endpoint. But this solution is not prioritized currently.
Implementation details
DockerTaskEngine.createContainermethod is updated so that it calls a newsetAWSLogsDualStackEndpointfunction if the instance is IPv6-only. This function usescloudwatchlogspackage from aws-sdk-go-v2 to resolve the dual stack endpoint for the logging region and set it asawslogs-endpointkey in the awslogs configuration.Testing
New tests cover the changes: yes
Ran a task on an IPv6-only instance and verified that logs are published to CloudWatch Logs. Also verified in Agent logs that Agent resolved the dual stack endpoint.
Description for the changelog
Enhancement: Agent resolves CloudWatch Logs dual stack endpoint on IPv6-only instances and sets it as
awslogs-endpointoption for awslogs logging driverAdditional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.