IPv6-only support for S3 clients#4580
Merged
Merged
Conversation
d23de2f to
c41b739
Compare
c41b739 to
411054c
Compare
amogh09
reviewed
Apr 21, 2025
9477d45 to
5d08a22
Compare
5d08a22 to
12e06af
Compare
amogh09
previously approved these changes
Apr 22, 2025
singholt
reviewed
Apr 23, 2025
singholt
previously approved these changes
Apr 23, 2025
cd1ac65 to
ddd8de7
Compare
ddd8de7 to
e3eb5d2
Compare
e3eb5d2 to
85b212f
Compare
85b212f to
2b6d42a
Compare
amogh09
approved these changes
Apr 24, 2025
singholt
reviewed
Apr 24, 2025
singholt
approved these changes
Apr 24, 2025
timj-hh
pushed a commit
to timj-hh/amazon-ecs-agent
that referenced
this pull request
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables S3 and S3Manager clients to automatically use dualstack endpoints when running on IPv6-only instances.
Implementation details
NewS3ManagerClientandNewS3Clientto acceptIPCompatibilityparametercreateAwsConfigto setuseDualStackEndpointbased on IPv6 compatibility statusTaskResourcessuch asEnvFiles,Firelens, andCredentialSpecs.ipCompatibilityfield to each task resource.New*constructors to accept an additionalipCompatibilityparameter.New*is invoked when there's a new incoming task that requires task resources.Config.InstanceIPCompatibilityis the source of value*ConfigtoInitialize().Initialize()is invoked when Agent restarts and reinitialize task resoucesNewCredentialsMetadataSetterto accept anIPCompatibilityparametercheckAndSetDomainlessGMSATaskExecutionRoleCredentialsImplto use theIPCompatibilityparameter when creating theCredentialSpecResourceTesting
Executed functional test suite on dualstack subnet. Verified all tests passed and dualstack endpoint usage through docker container logs.
Setups done:
IPCompatibilitytoNewIPv6OnlyCompatibilityawsConfigtoDebuglevel and directed logs toos.Stdout.New tests cover the changes: yes
TestCreateAWSConfigto remove redundant testConfigDescription for the changelog
Enhancement: S3 and S3Manager clients resolves to dualstack endpoint on IPV6-only instances
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.