Continue migrating ecs-agent module to aws-sdk-go-v2#4583
Merged
Conversation
Yiyuanzzz
changed the title
Yiyuanzzz
changed the title
harishxr
reviewed
Apr 24, 2025
harishxr
approved these changes
Apr 24, 2025
prateekchaudhry
approved these changes
Apr 24, 2025
timj-hh
pushed a commit
to timj-hh/amazon-ecs-agent
that referenced
this pull request
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues the migration of the ecs-agent module to aws-sdk-go-v2.
It updates additional files to use SDK v2，a few files still remain and will be migrated in follow-up PRs.
Implementation details
aws/arn, andaws/requestwere updated to their v2 equivalentsaws.StringValue,aws.Int32Value,aws.Bool,aws.StringValueSlicewere replaced withaws.ToString,aws.ToInt32，aws.ToBool, andaws.ToStringSlice.Testing
New tests cover the changes: no
Description for the changelog
Enhancement: Migrated more
ecs-agentfiles to useaws-sdk-go-v2Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.