[ON HOLD]Add InstanceStorageMetrics struct to TMDS v4 response.#4896
Open
[ON HOLD]Add InstanceStorageMetrics struct to TMDS v4 response.#4896
Conversation
xxx0624
previously approved these changes
Mar 17, 2026
hoshank10
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add InstanceStorageMetrics struct to TMDS v4 response. We want to expose both `InstanceDataFilesystemUtilization` and `InstanceOSFilesystemUtilization` through TMDS. The metrics are sent to TACS already to be present via container Insights. Generally, whatever is available via CI should be available via TMDS.Local storage uses the same metric and is needed to be exposed via TMDS.
Testing
existing tests pass.Description for the changelog
Enhancement - Add InstanceStorageMetrics struct to TMDS v4 response.Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
NoDoes this PR include the addition of new environment variables in the README?
NoLicensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.