Refactor state_test.go#4973
Open
tessaSlice wants to merge 4 commits into
Open
Conversation
added 2 commits
May 26, 2026 22:14
add newline to state_test.go
TheanLim
reviewed
May 28, 2026
| var err = NewErrorLookupFailure("reason") | ||
|
|
||
| require.True(t, errors.As(err, &target)) | ||
| assert.Equal(t, err, target) |
Contributor
There was a problem hiding this comment.
You are leaving out this pointer identity check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored
state_test.goto be table driven.Implementation details
Consolidated all the Error Failure cases into
Error.Astestcases where there's a match and testcases when there's not a match.Testing
Ran
make testlocally and checked that all outputs passed.New tests cover the changes: yes
Description for the changelog
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.