Skip to content

add support for system tcp keepalive options #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

colin-rogers-dbt
Copy link

Description

Currently the connector doesn't allow users to configure detailed keepalive settings on the socket requiring them to modify their system or session settings. This can be a challenge as many users are unfamiliar with these settings and even if they are they may not have access to those system settings or those settings can impact connecting to other applications.

Please note this PR is a rough proposal, likely needs some refinement and has not been properly tested. Happy to do more here if we're aligned on this approach.

Motivation and Context

See issue: #252 (comment)

Testing

TBD, more to come

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • Local run of ./build.sh succeeds
  • Code changes have been run against the repository's pre-commit hooks
  • Commit messages follow Conventional Commit Specification
  • I have read the README document
  • I have added tests to cover my changes
  • I have run all unit tests using pytest test/unit and they are passing.
  • By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant