(aws-ec2): Add Windows Server 2025 to WindowsVersion enum #33497
Labels
@aws-cdk/aws-ec2
Related to Amazon Elastic Compute Cloud
feature-request
A feature should be added or improved.
p2
Comments
invalidexplorer
added
feature-request
github-actions
bot
added
the
@aws-cdk/aws-ec2
This was referenced Feb 18, 2025
GavinZZ
added
p2
and removed
needs-triage
mergify bot
pushed a commit
that referenced
this issue
Feb 19, 2025
### Issue # (if applicable) Closes #33497 (aws-ec2): Add Windows Server 2025 to WindowsVersion enum ### Reason for this change The AWS License Manager team requires Windows Server 2025 support in the WindowsVersion enum to build production-ready EC2 image pipelines. ### Description of changes Added new enum values in packages/@aws-cdk/aws-ec2/lib/windows-versions.ts: ``` WINDOWS_SERVER_2025_ENGLISH_FULL_BASE = 'Windows_Server-2025-English-Full-Base', WINDOWS_SERVER_2025_ENGLISH_CORE_BASE = 'Windows_Server-2025-English-Core-Base' ``` - No breaking changes introduced - Maintains consistent naming convention with existing enum values - Describe any new or updated permissions being added - No new IAM permissions are required for this change as it only extends the existing enum with additional values. ### Description of how you validated changes **Existing Unit Tests:** - Ran all existing unit tests to ensure no regressions - Confirmed all tests pass successfully with the new enum values added **Manual Testing:** - Tested in development environment - Verified correct AMI resolution using the new enum values **Checklist** [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) [x] My code adheres to the [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) [ ] Added new unit tests (No new tests added, verified against existing tests) [ ] Added integration tests (Manual testing performed) [x] Followed existing enum naming conventions
|
Comments on closed issues and PRs are hard for our team to see. |
yashkh-amzn
pushed a commit
to yashkh-amzn/aws-cdk
that referenced
this issue
Feb 21, 2025
### Issue # (if applicable) Closes aws#33497 (aws-ec2): Add Windows Server 2025 to WindowsVersion enum ### Reason for this change The AWS License Manager team requires Windows Server 2025 support in the WindowsVersion enum to build production-ready EC2 image pipelines. ### Description of changes Added new enum values in packages/@aws-cdk/aws-ec2/lib/windows-versions.ts: ``` WINDOWS_SERVER_2025_ENGLISH_FULL_BASE = 'Windows_Server-2025-English-Full-Base', WINDOWS_SERVER_2025_ENGLISH_CORE_BASE = 'Windows_Server-2025-English-Core-Base' ``` - No breaking changes introduced - Maintains consistent naming convention with existing enum values - Describe any new or updated permissions being added - No new IAM permissions are required for this change as it only extends the existing enum with additional values. ### Description of how you validated changes **Existing Unit Tests:** - Ran all existing unit tests to ensure no regressions - Confirmed all tests pass successfully with the new enum values added **Manual Testing:** - Tested in development environment - Verified correct AMI resolution using the new enum values **Checklist** [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) [x] My code adheres to the [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) [ ] Added new unit tests (No new tests added, verified against existing tests) [ ] Added integration tests (Manual testing performed) [x] Followed existing enum naming conventions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the feature
Request to add Windows Server 2025 support in the WindowsVersion enum within the AWS CDK EC2 module. This addition is crucial for the AWS License Manager team's EC2 image pipeline workflows.
Use Case
As part of the AWS License Manager team, we are building EC2 image pipelines that require Windows Server 2025 support. Our EC2 Image Builder pipeline specifically depends on the aws-ec2 lib/WindowsVersion enum to retrieve Windows version names for image naming conventions. Currently, due to the absence of Windows 2025 in the enum:
We are forced to use hardcoded values as a temporary solution:
Proposed Solution
Update the WindowsVersion enum in packages/@aws-cdk/aws-ec2/lib/windows-versions.ts to include Windows Server 2025 entries:
export enum WindowsVersion {
// ... existing versions ...
WINDOWS_SERVER_2025_ENGLISH_FULL_BASE = 'Windows_Server-2025-English-Full-Base',
WINDOWS_SERVER_2025_ENGLISH_CORE_BASE = 'Windows_Server-2025-English-Core-Base',
}
Other Information
Current Impact: The lack of Windows 2025 support affects the License Manager team's ability to build standardized production pipelines
Related Documentation: https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2.WindowsVersion.html
Change Type: Non-breaking addition to existing enum
Implementation Complexity: Low (simple enum extension)
Acknowledgements
CDK version used
aws-cdk: 2.178.2 aws-cdk-lib: 2.178.2
Environment details (OS name and version, etc.)
OS: Amazon Linux 2 (Karoo) EC2 Instance Type: c5.4xlarge System Manufacturer: Amazon EC2
The text was updated successfully, but these errors were encountered: