-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ec2): add Windows Server 2025 to WindowsVersion enum #33499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33499 +/- ##
=======================================
Coverage 82.16% 82.16%
=======================================
Files 119 119
Lines 6857 6857
Branches 1157 1157
=======================================
Hits 5634 5634
Misses 1120 1120
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #33497 (aws-ec2): Add Windows Server 2025 to WindowsVersion enum
Reason for this change
The AWS License Manager team requires Windows Server 2025 support in the WindowsVersion enum to build production-ready EC2 image pipelines.
Description of changes
Added new enum values in packages/@aws-cdk/aws-ec2/lib/windows-versions.ts:
Description of how you validated changes
Existing Unit Tests:
Manual Testing:
Checklist
[x] My code adheres to the CONTRIBUTING GUIDE
[x] My code adheres to the DESIGN GUIDELINES
[ ] Added new unit tests (No new tests added, verified against existing tests)
[ ] Added integration tests (Manual testing performed)
[x] Followed existing enum naming conventions