Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codepipeline-actions): support InspectorEcrImageScanAction and InspectorSourceCodeScanAction actions #33378

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Feb 11, 2025

TODO

  • implementation
  • unit tests
  • integ tests
  • README

Issue # (if applicable)

Closes #33377.

Reason for this change

AWS CodePipeline introduces new build action: InspectorScan action.

Description of changes

Add InspectorEcrImageScanAction and InspectorSourceCodeScanAction classes that extends BaseInspectorScan class.

The BaseInspectorScan class that extends Action class to aws-codepipeline-actions module.

Describe any new or updated permissions being added

Description of how you validated changes

Both unit and integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 11, 2025 08:00
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Feb 11, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (c400e0e) to head (e545b9c).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33378      +/-   ##
==========================================
- Coverage   80.92%   80.92%   -0.01%     
==========================================
  Files         236      236              
  Lines       14256    14255       -1     
  Branches     2491     2491              
==========================================
- Hits        11537    11536       -1     
  Misses       2434     2434              
  Partials      285      285              
Flag Coverage Δ
suite.unit 80.92% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.74% <ø> (-0.01%) ⬇️
packages/aws-cdk-lib/core 82.20% <ø> (ø)

@go-to-k go-to-k changed the title feat(codepipeline-actions): support InspectorScan invoke action feat(codepipeline-actions): support InspectorScan action Feb 11, 2025
@go-to-k go-to-k changed the title feat(codepipeline-actions): support InspectorScan action feat(codepipeline-actions): support EcrImageScanAction and SourceCodeScanAction action Feb 11, 2025
@go-to-k go-to-k changed the title feat(codepipeline-actions): support EcrImageScanAction and SourceCodeScanAction action feat(codepipeline-actions): support EcrImageScanAction and SourceCodeScanAction actions Feb 11, 2025
@go-to-k go-to-k changed the title feat(codepipeline-actions): support EcrImageScanAction and SourceCodeScanAction actions feat(codepipeline-actions): support InspectorEcrImageScanAction and InspectorSourceCodeScanAction actions Feb 11, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e545b9c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codepipeline-actions: support InspectorScan action
2 participants