Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions): support JSONATA for result writer and item reader #33404

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Feb 12, 2025

Issue # (if applicable)

Closes #33396.

Reason for this change

Result writer and item reader class do not support using JSONATA. Deployment will fails due to if SFN is set to use JSONATA, it expects Arguments in the ASL instead of Parameters.

Description of changes

Support JSONATA as the query language.

Description of how you validated changes

New unit test and new integ test with assertions

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. p2 labels Feb 12, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 12, 2025 00:55
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.92%. Comparing base (a7d7373) to head (88d882d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33404   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files         236      236           
  Lines       14255    14255           
  Branches     2491     2491           
=======================================
  Hits        11536    11536           
  Misses       2434     2434           
  Partials      285      285           
Flag Coverage Δ
suite.unit 80.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.74% <ø> (ø)
packages/aws-cdk-lib/core 82.20% <ø> (ø)

@GavinZZ GavinZZ added the pr/do-not-merge This PR should not be merged at this time. label Feb 12, 2025
@GavinZZ
Copy link
Contributor Author

GavinZZ commented Feb 12, 2025

Marking this PR as pr/do-not-merge. Pending a review from @WinterYukky prior to merge this change.

Also update the PR label to correctly reflect the issue priority.

@GavinZZ GavinZZ added p1 and removed p2 labels Feb 12, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 88d882d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p1 pr/do-not-merge This PR should not be merged at this time. pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stepfunctions: resultwriter on jsonata distributed maps fails deployments
2 participants