chore(cli-integ): make the version of cli-lib-alpha switchable
#33450
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `@aws-cdk/cli-lib-alpha` package is vended as an alpha package in the old pipeline. That means its version number is `2.178.1-alpha.0` for a real release, or `2.178.1-alpha.999` for a release candidate, with the version component matching the framework version. In the new pipeline, we'll have to decouple from the framework version to the CLI version anyway, and I don't want to have to rebuild this version mangling logic in projen. Instead, we'll just give the library the exact same version as the CLI. Its alpha status is still obvious enough from its name, so I don't think that will be a problem.
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33450 +/- ##
=======================================
Coverage 81.00% 81.00%
=======================================
Files 238 238
Lines 14271 14271
Branches 2492 2492
=======================================
Hits 11560 11560
Misses 2425 2425
Partials 286 286
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
mrgrain
approved these changes
Feb 14, 2025
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@aws-cdk/cli-lib-alphapackage is vended as an alpha package in the old pipeline.That means its version number is
2.178.1-alpha.0for a real release, or2.178.1-alpha.999for a release candidate, with the version component matching the framework version.In the new pipeline, we'll have to decouple from the framework version to the CLI version anyway, and I don't want to have to rebuild this version mangling logic in projen. Instead, we'll just always take the CLI version and append
-alpha.0. That may mean we'll end up with a release candidate version of-rc.0-alpha.0, which looks weird but I don't think will break anything.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license