Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove service spec yarn resolutions #33485

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Feb 18, 2025

These resolutions prevent us from fetching the latest schema. They were added because there are multiple breaking changes in the spec we weren't ready to accept yet.

Are we ready to accept the new spec?

Not quite.

So whats the plan?

We need to remove these resolutions in order to get a service spec update PR that at least surfaces all the breaking changes in order to work on them. So the plan is:

  1. Merge this PR.
  2. Run the spec update workflow
  3. Slap a pr/do-not-merge label on the resulting PR
  4. Figure out what to do with the breaking changes it show.
  5. Eventually merge the spec update after applying patches or allowing breaking changes to go through.

From a local execution at the time of writing this PR, those breaking changes should be:

├[~] service aws-cognito
│ └ resources
│    └[~]  resource AWS::Cognito::UserPoolDomain
│       └ attributes
│          └[-] Id: string


├[~] service aws-dynamodb
│ └ resources
│    └[~]  resource AWS::DynamoDB::GlobalTable
│       └ properties
│          └[-] PointInTimeRecoverySpecification: PointInTimeRecoverySpecification


│    ├[~]  resource AWS::ECS::Service
│    │  ├ properties
│    │  │  ├ AvailabilityZoneRebalancing: (documentation changed)
│    │  │  └ CapacityProviderStrategy: (documentation changed)
│    │  └ types
│    │     └[~] type ServiceManagedEBSVolumeConfiguration
│    │       └ properties
│    │          └[-] VolumeInitializationRate: integer


│    └[~]  resource AWS::RDS::GlobalCluster
│       ├ properties
│       │  └[-] GlobalEndpoint: GlobalEndpoint
│       └ attributes
│          └[+] GlobalEndpoint: GlobalEndpoint

Wait but you just detailed the breaking changes, can't we just work based of that?

No, we shouldn't be operating on the basis of local executions. The local execution diff is just to get a sense and show that there are indeed a few breaking changes already present.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team February 18, 2025 07:17
@github-actions github-actions bot added the p2 label Feb 18, 2025
@iliapolo
Copy link
Contributor Author

Adding pr/do-not-merge on this one because there is some coordination needed immediately after and I have to step out for a bit.

@iliapolo iliapolo added the pr/do-not-merge This PR should not be merged at this time. label Feb 18, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 18, 2025
@iliapolo iliapolo changed the title chore: remove service spec yarn resolutions chore: remove temporary service spec resolutions and overrides Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (c7a9a3c) to head (713584a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33485   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files         238      238           
  Lines       14271    14271           
  Branches     2492     2492           
=======================================
  Hits        11560    11560           
  Misses       2425     2425           
  Partials      286      286           
Flag Coverage Δ
suite.unit 81.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.92% <ø> (ø)
packages/aws-cdk-lib/core 82.16% <ø> (ø)

This reverts commit 14c914b.
@iliapolo iliapolo changed the title chore: remove temporary service spec resolutions and overrides chore: remove service spec yarn resolutions Feb 18, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 713584a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 18, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 18, 2025
@iliapolo iliapolo removed the pr/do-not-merge This PR should not be merged at this time. label Feb 18, 2025
Copy link
Contributor

mergify bot commented Feb 18, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 411dc5a into main Feb 18, 2025
39 checks passed
@mergify mergify bot deleted the epolon/remove-spec-resolutions branch February 18, 2025 08:57
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants